Fix consistency check for merged sbundles #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7daa49 to
e607319
Compare
Benchmark results for
|
| Date (UTC) | 2024-07-24T15:14:00+00:00 |
| Commit | e607319ad82cd7fcfb78b9c62d60a7e1a0804a71 |
| Base SHA | ae24579813ba4eda3d5c5469f4a107900516d7ee |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| MEV-Boost SubmitBlock serialization/JSON encoding | 7.84% | Performance has degraded. |
MoeMahhouk
pushed a commit
that referenced
this pull request
Jul 29, 2024
There were situations where we had merged sbundles that looked like this bundle1: user_tx, allow_revert: no backrun1 bundle 2: user_tx: allow_revert yes backrun merged sbundle is concat of these two and consistency check would think that user_tx wat not allowed to revert enven though there is a situation where we include bundle2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were situations where we had merged sbundles that looked like this
bundle1:
user_tx, allow_revert: no
backrun1
bundle 2:
user_tx: allow_revert yes
backrun
merged sbundle is concat of these two
and consistency check would think that user_tx wat not allowed to revert enven though there is a situation where we include bundle2