Add support for using Windows named pipes #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
One very common way of hosting node applications on Windows is to host them in IIS using iisnode.
iisnode provides the available port as a Windows named pipe and not as a port number in the environment variable
port
. Node can open named pipes, however theparse_address()
function inutils.js
does not allow them, so Sinopia cannot be hosted in iisnode on Windows.This PR fixes that.
What's changed
This PR does not change any of the existing behavior, if a port number or url has been specified it's still used.
However, if it's not one of those a check is made to see if the incoming port looks like a Windows named pipe, and in that case uses that.
This PR also fixes logging so correct protocol is logged, and add tests for Windows named pipes.
How to host Sinopia in iisnode
With this PR Sinopia can be used in iisnode by creating a project,
npm install --save sinopia2
and then createindex.js
:Configure iisnode to use
index.js
as start file.Named pipes
A named pipe in Windows has the format:
\\.\pipe\PipeName
PipeName
can include any characterother than a backslash, including numbers and special characters.
From: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365783(v=vs.85).aspx