Inline mode #157
Inline mode #157
Conversation
|
Looks more like a proof of concept than a real pull request :) But with this changes Inline mode works. |
| @@ -34,13 +34,28 @@ data InlineQuery = InlineQuery | |||
| , inlineQueryLocation :: Maybe Location -- ^ For bots that require user location, sender location | |||
| , inlineQueryQuery :: Text -- ^ Text of the query, up to 256 characters | |||
| , inlineQueryOffset :: Text -- ^ Offset of the results to be returned, can be controlled by bot | |||
| , inlineQueryChatType :: Maybe ChatType -- ^ Type of the chat, from which the inline query was sent. Can be either “sender” for a private chat with the inline query sender, “private”, “group”, “supergroup”, or “channel”. The chat type should be always known for requests sent from official clients and most third-party clients, unless the request was sent from a secret chat. | |||
There was a problem hiding this comment.
Could you please extend ChatType instead of introducing InlineChatType?
There was a problem hiding this comment.
I've thought about it, my reasons were: ChatType which is in Chat can not be sender:
Type of chat, can be either “private”, “group”, “supergroup” or “channel”
So if someone is pattern matching against this field now he would get non-exhaustive patterns, and will also have to handle this non-existent case. This way i was trying to minimize damage to existing code which uses the library.
But, yes, I can also see the reasons against it.
There was a problem hiding this comment.
Okay, as far as I see there are no usages of ChatType. Could you please remove it in favour of InlineChatType then?
| @@ -1,7 +1,7 @@ | |||
| cabal-version: 1.12 | |||
|
|
|||
| name: telegram-bot-api | |||
| version: 6.7 | |||
| version: 6.7.1 | |||
There was a problem hiding this comment.
Could you please undo this change? It breaks my maintenance flow.
|
@swamp-agr Haven't seen your last comment, so I've removed
|
|
Thank you! Please expect release tomorrow. |
|
Please find the release on Hackage https://hackage.haskell.org/package/telegram-bot-api-6.7.1 (Haddock will be ready in a few days) |
inlineQueryChatTypeto supportsendertype (Inline mode is broken #156)Maybesomewhere closer totoJSON. For each field independently, somewhere along the lines of[ "normal_field" .= normal_field ] ++ maybe [] (\value -> ["maybe_field" .= value]) maybe_field