Make methods virtual #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,19 @@ | |||
| #include <fixposition_driver_lib/helper.hpp> | |||
| #include <fixposition_driver_lib/parser.hpp> | |||
|
|
|||
| #ifndef B460800 | |||
There was a problem hiding this comment.
Hi @floriansegginger, thanks for the MR. Can you explain what's going on with these defs?
There was a problem hiding this comment.
See my comment in #29
These baud rates aren't part of the default ones provided on MacOS and they make compilation fail.
|
@floriansegginger Thanks for the PR, we merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make methods of FixpositionDriver virtual so the class is extendable