Audio streaming training with masking #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farzadab
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Thanks Saeed. I left some comments.
It would be ideal to add some tests, for example to make sure the structure of the mask matches what we expect. If you can think of another test feel free to add one.
I know the repo doesn't have many tests, but we'd like to change that.
|
@farzadab Hi, |
farzadab
reviewed
Nov 19, 2024
Co-authored-by: Farzad Abdolhosseini <farzad.abdolhosseini@gmail.com>
|
@farzadab, I utilized 'just test', and 'just format', and corrected mentioned issues. |
farzadab
approved these changes
Nov 19, 2024
farzadab
reviewed
Nov 19, 2024
Co-authored-by: Farzad Abdolhosseini <farzad.abdolhosseini@gmail.com>
Co-authored-by: Farzad Abdolhosseini <farzad.abdolhosseini@gmail.com>
|
@farzadab solved. |
akshat0311
pushed a commit
to jiviai/audio-llm
that referenced
this pull request
Jan 30, 2025
* Audio streaming training with masking * ultravox_model test --------- Co-authored-by: Farzad Abdolhosseini <farzad.abdolhosseini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By utilizing a mask, we can simulate audio streaming.