-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break up datasets.py #141
Merged
Merged
Break up datasets.py #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits out types.py and registry.py to move the list of pre-defined datasets to its own file and avoid circular refs. An __all__ import is used to minimize changes to surrounding code.
zqhuang211
approved these changes
Oct 21, 2024
farzadab
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
akshat0311
pushed a commit
to jiviai/audio-llm
that referenced
this pull request
Jan 30, 2025
* Break up datasets.py This splits out types.py and registry.py to move the list of pre-defined datasets to its own file and avoid circular refs. An __all__ import is used to minimize changes to surrounding code. * sr * cr * merge * restore typing
zqhuang211
pushed a commit
that referenced
this pull request
Feb 12, 2025
* Fix typo in README.md (#128) * [bugfix] Missing enable_fsdp in 70b config (#132) * Update load warnings (#126) * Generic datasets with inheritance (#135) * Switch InterleaveDataset to use weights (e.g., 2.0, 0.5, etc) (#140) * Break up datasets.py (#141) * Update registry with more languages commonvoice (#143) * Split dataset definitions into individual files (#145) * Add whisper masking (#146) * Defining block size in UltravoxConfig, and solving assertions (#157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out types.py and registry.py to move the list of pre-defined datasets to its own file and avoid circular refs.
An all import is used to minimize changes to surrounding code.