[70B-Part1] Prefetch weights separately #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liPatrick I'm gonna add you to the PRs for visibility. You don't have to do the review. |
juberti
reviewed
Sep 11, 2024
farzadab
commented
Sep 11, 2024
farzadab
commented
Sep 11, 2024
zqhuang211
reviewed
Sep 12, 2024
zqhuang211
reviewed
Sep 12, 2024
zqhuang211
reviewed
Sep 12, 2024
akshat0311
pushed a commit
to jiviai/audio-llm
that referenced
this pull request
Jan 30, 2025
* prefetch weights separately * moving get_train_args to config * add a test for prefetch_weights * double check for prefetch_weights for local/test runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for downloading the weights of the model first, before starting the DDP processes. The previous approach tends to time out when using 70B model.