Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate timezone and daylight tables #24

Merged
merged 18 commits into from
Feb 16, 2022
Merged

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jan 21, 2022

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

  • adds daylight_time and time_zone staging models and macros
  • adds seed data for new source tables
  • adds postgres run to circle ci setup (the transform package already had it but not the source 🤷‍♂️ ) --> ok removed this for now as i can now see that we probably didn't include postgres here because it's a bit complicated... i can address this later but just wanna make sure it runs on the other warehouses for now
  • adjusts circle ci dbt runs to be a bit more thorough...
  • adds documentation + tests for the new tables/models
  • update package version ?

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

uhhhhhh yes i think??? anyways v0.8.0 of the transform package will be a breaking change right?

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)
    tested locally on BQ

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🐶

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added bug Something isn't working enhancement New feature or request labels Jan 24, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the time_zone and daylight_time tables looks great @fivetran-jamie! The hoops you have to jump through to extract the offset is pretty wild. Great job!

I have a few small inline comments. Additionally, a few things that we should update before we merge.

  • Add the description of the updates here to the CHANGELOG
  • Since we are swapping out the start/end_time_utc fields in the schedule model we will want to have this be a breaking change on the source as well. Can you be sure to reflect that in this PR.
  • Regenerate the docs
  • The Postgres CircleCi may just need the default column to be quoted since it is a reserved word 🤷

models/stg_zendesk__time_zone.sql Show resolved Hide resolved
models/stg_zendesk.yml Show resolved Hide resolved
models/src_zendesk.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-jamie fivetran-jamie merged commit 8585a95 into main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants