Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4.0] Upgrade to dbt v0.20 #16

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jul 14, 2021

(same basic story as fivetran/dbt_hubspot_source#46)

Are you a current Fivetran customer?
Jeremy Cohen, dbt Labs, yes!

What change(s) does this PR introduce?

  • Require fivetran_utils: [">=0.2.0", "<0.3.0"]. Lower + upper since you have full control over this package, and can release it whenever you need.
  • Require dbt >= 0.20.0. Just a lower bound because we can rely on dbt_utils (via fivetran_utils) to hold the upper dbt bound for us.
  • Bump project version (cosmetic only)
  • Bump dbt version in integration tests, and remove dbt version requirement from integration tests dbt_project.yml — this will just use the dbt version requirement in the packages it depends on

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

Is this PR in response to a previously created Issue

  • Yes, Issue [link issue number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

I ran this on Postgres, everything passed, with one tiny change: I needed to wrap quotes around the default column in brand_data, since default is a reserved word in Postgres.

dbt deps
dbt seed
dbt run
dbt test

As before, happy to run against the other warehouses if you'd like. With an update like this, if the package parses/compiles/runs right on one, it ought to across the board.

Provide an emoji that best describes your current mood

🕴️ 🕴️

@jtcohen6
Copy link
Contributor Author

I realize I accidentally included an edit to integration_tests/data/brand_data.csv that wrapped a column named default in quotes. This was needed to run integration tests on Postgres locally, but it doesn't make sense to include as part of this PR.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from master to feature/jtcohen-dbt20-upgrade July 19, 2021 23:08
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for tackling this PR for dbt 0.20.0 compatibility 🕺

Before I merge to master I am going to approve and merge to the staging feature/jtcohen-dbt20-upgrade branch to check that the changes pass our cross warehouse tests.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 6bf2b66 into fivetran:feature/jtcohen-dbt20-upgrade Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants