bugfix/sla_duplicates

CHANGELOG.md

@@ -1,3 +1,6 @@
+# dbt_zendesk v0.8.1
+## Fixes
+- The `0.7.1` release of the zendesk package introduced a bug within the `zendesk__sla_policy` model that caused duplicate sla records via a [join condition](https://github.com/fivetran/dbt_zendesk/blob/v0.7.1/models/sla_policy/int_zendesk__sla_policy_applied.sql#L48). This join condition has been modified to leverage the more accurate `sla_policy_applied.valid_starting_at` field instead of the `sla_policy_applied.sla_applied_at` which changes for `first_reply_time` slas. ([#67](https://github.com/fivetran/dbt_zendesk/pull/67))
 # dbt_zendesk v0.8.0
 ## 🚨 Breaking Changes 🚨
 - The logic used to generate the `zendesk__ticket_backlog` model was updated to more accurately map backlog changes to tickets. As the underlying `zendesk__ticket_field_history` model is incremental, we recommend a `--full-refresh` after installing this latest version of the package. ([#61](https://github.com/fivetran/dbt_zendesk/pull/61))

dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'zendesk'
-version: '0.8.0'
+version: '0.8.1'
 
 config-version: 2
 require-dbt-version: [">=1.0.0", "<2.0.0"]

integration_tests/ci/sample.profiles.yml

@@ -32,7 +32,7 @@ integration_tests:
       method: service-account
       keyfile: "{{ env_var('GCLOUD_SERVICE_KEY_PATH') }}"
       project: 'dbt-package-testing'
-      schema: zendesk_integration_tests
+      schema: zendesk_integration_test
       threads: 8
     snowflake:
       type: snowflake

integration_tests/dbt_project.yml

@@ -1,7 +1,7 @@
 config-version: 2
 
 name: 'zendesk_integration_tests'
-version: '0.8.0'
+version: '0.8.1'
 
 profile: 'integration_tests'
 

models/sla_policy/int_zendesk__sla_policy_applied.sql

@@ -26,6 +26,7 @@ with ticket_field_history as (
   select
     ticket_field_history.ticket_id,
     ticket.created_at as ticket_created_at,
+    ticket_field_history.valid_starting_at,
     ticket.status as ticket_current_status,
     ticket_field_history.field_name as metric,
     case when ticket_field_history.field_name = 'first_reply_time' then row_number() over (partition by ticket_field_history.ticket_id, ticket_field_history.field_name order by ticket_field_history.valid_starting_at desc) else 1 end as latest_sla,
@@ -45,8 +46,8 @@ with ticket_field_history as (
   from sla_policy_applied
   left join sla_policy_name
     on sla_policy_name.ticket_id = sla_policy_applied.ticket_id
-      and sla_policy_applied.sla_applied_at >= {{ fivetran_utils.timestamp_add(datepart='second', interval='-5', from_timestamp='sla_policy_name.valid_starting_at') }}
-      and sla_policy_applied.sla_applied_at < coalesce(sla_policy_name.valid_ending_at, {{ dbt_utils.current_timestamp() }}) 
+      and sla_policy_applied.valid_starting_at >= sla_policy_name.valid_starting_at
+      and sla_policy_applied.valid_starting_at < coalesce(sla_policy_name.valid_ending_at, {{ dbt_utils.current_timestamp() }}) 
   where sla_policy_applied.latest_sla = 1
 )