feature/first_reply_time_hours_performance_fix #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fivetran-catfritz
approved these changes
Apr 29, 2024
414849d
into
bugfix/duplicate_sla_event_ids_from_dst
8 checks passed
fivetran-jamie
added a commit
that referenced
this pull request
Jun 25, 2024
* cast from timestamp to date * reduce week generate from 208 to 52 * Update int_zendesk__reply_time_combined.sql try different order of operations * update schedule spine to explode out holiday periods * forgot to add dbt timestamp * addd timestamp cast and update test schema * guess this didnt get staged * new schema? * remove the extra parenthesis that was just used for testing * documentation/streamlit-report-addition (#149) * documentation/streamlit-report-addition * Update CHANGELOG.md * Update README.md * no changes to reply time combined * versioning and changelog * feature/first_reply_time_hours_performance_fix (#152) * feature/first_reply_time_hours_performance_fix * cleanup adjustments and documentation * fix for databricks * changelog * Update models/sla_policy/reply_time/int_zendesk__reply_time_business_hours.sql Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> * decision log * more updates on changelog * up version * docs * bugfix/remianing-sla-issues * validation additions * changelog addition * Update CHANGELOG.md Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com> * moving tests and adding new ones * changelog update and requirements limit * Update CHANGELOG.md Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com> * dics * customer metrics drafted * bk * switch schedule --------- Co-authored-by: Renee Li <renee.li@fivetran.com> Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #151
This PR will result in the following new package version: v0.14.1
This will be a non breaking change and planned to be incorporated into the upcoming release.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Detailed validation includes two customers confirming that these changes drastically improved the performance of the
int_zendesk__reply_time_business_hoursmodel. No further validation required.If you had to summarize this PR in an emoji, which would it be?
🚤