Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update history staging models with correct active records #4

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Feb 16, 2024

PR Overview

This PR will address the following Issue/Feature:
#3

This PR will result in the following new package version:
v0.1.1

This will update records for customers going forward

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

PR #4 contains the following updates:

  • Updates the filtering done in the history staging models to pull the correct active statuses. Since some changes are entered but not yet effective, we needed to replace the _fivetran_active filter to where current timestamp is between _fivetran_start and _fivetran_end times for each record.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned.
  • All necessary documentation and version upgrades have been applied.
  • docs were regenerated (unless this PR does not include any code or yml updates).
  • BuildKite integration tests are passing.
  • Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

linked in height!

If you had to summarize this PR in an emoji, which would it be?

📖

@fivetran-reneeli
Copy link
Contributor Author

  • regen docs

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli this looks great! The only thing holding me back from approving is the question around the use of the current_timestamp_backcompat macro. Would you be able to look into my remaining question and let me know if this is still necessary or if we should switch to using current_timestamp.

Once you come to an answer I can re-review and approve.

CHANGELOG.md Show resolved Hide resolved
models/staging/stg_workday__personal_information.sql Outdated Show resolved Hide resolved
fivetran-reneeli and others added 2 commits February 20, 2024 17:24
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for looking into the remaining questions and applying the appropriate updates. This looks good to go with one last suggestion to update the CHANGELOG with the additional changes.

After that this is good to have docs regen'd and the release review process initiated.

CHANGELOG.md Show resolved Hide resolved
@fivetran-reneeli fivetran-reneeli merged commit 7f0441e into main Feb 21, 2024
8 checks passed
@fivetran-reneeli fivetran-reneeli deleted the bugfix/current_active branch February 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] _fivetran_active can pull future dated records from worker_history rather than the currently active one
2 participants