-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update history staging models with correct active records #4
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli this looks great! The only thing holding me back from approving is the question around the use of the current_timestamp_backcompat
macro. Would you be able to look into my remaining question and let me know if this is still necessary or if we should switch to using current_timestamp
.
Once you come to an answer I can re-review and approve.
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for looking into the remaining questions and applying the appropriate updates. This looks good to go with one last suggestion to update the CHANGELOG with the additional changes.
After that this is good to have docs regen'd and the release review process initiated.
PR Overview
This PR will address the following Issue/Feature:
#3
This PR will result in the following new package version:
v0.1.1
This will update records for customers going forward
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR #4 contains the following updates:
_fivetran_active
filter to where current timestamp is between_fivetran_start
and_fivetran_end
times for each record.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
linked in height!
If you had to summarize this PR in an emoji, which would it be?
📖