Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps #66

Merged
merged 9 commits into from
Oct 9, 2023
Merged

update deps #66

merged 9 commits into from
Oct 9, 2023

Conversation

fivetran-reneeli
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature: n/a

This PR will result in the following new package version: v0.10.0

Linked to the upstream update fivetran/dbt_shopify_source#75

Will require a full refresh to update the logic coming from dbt-date and dbt-expectations

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Updates the dependency versions to the most current

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Run with a full refresh

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • [ n/a] DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli mentioned this pull request Oct 4, 2023
Open
4 tasks
fivetran-joemarkiewicz
fivetran-joemarkiewicz requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request to make an update to the changelog

CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
# dbt_shopify v0.10.0
- Removes the dependency on [dbt-expectations](https://github.com/calogica/dbt-expectations/releases) and updates [dbt-date](https://github.com/calogica/dbt-date/releases) dependencies to the latest version. ([PR #66](https://github.com/fivetran/dbt_shopify/pull/66/))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a subheader here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally can we include the a section here that highlights the tests removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

packages.yml Outdated
Comment on lines 2 to 7
# - package: fivetran/shopify_source
# version: [">=0.10.0", "<0.11.0"]

- git: https://github.com/fivetran/dbt_shopify_source.git
revision: feature/update_deps
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update before merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

fivetran-joemarkiewicz
fivetran-joemarkiewicz approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a small request to more appropriately parse out the CHANGELOG entries into their own subheaders.

Once that is applied then this is good to go! Please remember to only merge this once the source package updates are live. Otherwise all of the buildkite jobs will show as failed.

CHANGELOG.md Outdated
# dbt_shopify v0.10.0
## Dependency Updates
- Removes the dependency on [dbt-expectations](https://github.com/calogica/dbt-expectations/releases) and updates [dbt-date](https://github.com/calogica/dbt-date/releases) dependencies to the latest version. ([PR #66](https://github.com/fivetran/dbt_shopify/pull/66/))
- Specifically we removed the `dbt_expectations.expect_table_row_count_to_equal_other_table` test that ensured no fanouts in the metafield models. We will be working to replace this with a similar test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in a different subheader. The dependency update is for just remove the dependency, but this should be listed as a general update.

Also, this should have a PR link

@fivetran-reneeli fivetran-reneeli merged commit dd3b971 into main Oct 9, 2023
@fivetran-reneeli fivetran-reneeli deleted the feature/update_deps branch October 9, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fivetran-joemarkiewicz fivetran-joemarkiewicz fivetran-joemarkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fivetran-reneeli @fivetran-joemarkiewicz