-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aggregate distinct customer ids in email rollup #58
aggregate distinct customer ids in email rollup #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fivetran-jamie! So it looks like the customer ids are distinct now, but the aggregation is still not changing and doesn't match with the order counts and amount summations for customer ids with multiple tags. Can you take a look at the issues I saw in int_shopify__customer_email_rollup
and see if there's validity to what I'm seeing? Thanks!
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
…thub.com/fivetran/dbt_shopify into bug/aggregate-only-distinct-customer-ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All's good! Whenever Databricks stops timing out you're good to release.
Are you a current Fivetran customer?
internal
What change(s) does this PR introduce?
distinct
to thefivetran_utils.string_agg
of customer ids inint_shopify__customer_email_rollup
lower()
to some spots we are looking at transaction.kind (i have always seen it as lowercase in the source data but just in case -- i changed this while investigating something and felt it didn't hurt to leave in)int_shopify__customer_email_rollup
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
no columns were changed -- the
customer_ids
field will just not aggregate duplicate IDsDid you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
before change:

after change:

Aggregated metrics tie out as well
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
👾
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.