discounts! #47
discounts! #47
Conversation
There was a problem hiding this comment.
@fivetran-jamie this is looking great! I have just a few comments, suggestions, and questions in my review below. Let me know if you have any questions.
| sum(order_discount_code.amount) as total_order_discount_amount, | ||
| sum(orders.total_line_items_price) as total_order_line_items_price, | ||
| sum(orders.shipping_cost) as total_order_shipping_cost, | ||
| sum(orders.refund_subtotal + orders.refund_total_tax) as total_order_refund_amount, |
There was a problem hiding this comment.
I could also see avg being a relevant metric when assessing discounts. Especially when it comes to percent values, I would be really interested to understand the average discount dollar amount. Who knows, maybe a 10% discount code is being used on large orders and is coming out to a super high average. I could see this being a useful metric.
What are your thoughts?
There was a problem hiding this comment.
oh yeah that's a good idea and will be very simple to add!
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
…vetran/dbt_shopify into feature/revamp/discount-model
There was a problem hiding this comment.
Thanks for addressing these notes @fivetran-jamie!! All looks good on my end!
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
adds discounts! to a new final model and aggregates them in shopify__orders
what i still need to do:
Did you update the CHANGELOG?
no, will be done in the documentation PR
Does this PR introduce a breaking change?
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
⚡
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.