Update README, add identifier #37
Conversation
There was a problem hiding this comment.
@fivetran-avinash these changes are looking good! I have a few requested edits. Ultimately for the README we should follow the same structure as our existing READMEs. You can see Twitter Organic as a good example of how we should group the steps.
Additionally, we should rebuild the docs now that you have the identifier variables implemented.
There was a problem hiding this comment.
@fivetran-joemarkiewicz All changes applied and deployed, ready for re-review!
There was a problem hiding this comment.
@fivetran-avinash thanks so much for applying the updates from my review and this is looking great!
I have just two small requests in this review. However, I am going to approve the PR as they are pretty minor changes that don't need to be re-reviewed. Once those two changes are applied, feel free to merge this into the feature/quickbooks-updates-project branch!
Are you a current Fivetran customer?
What change(s) does this PR introduce?
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
✒️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.