-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/credit card payments #29
Feature/credit card payments #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! left a couple of docs-related comments
just flagging that this package still uses the ~= syntax in the requirements.txt file if we want to change it to >=
note: i do not have access to our quickbooks schema, so i did not run this myself as the customer is also testing it out and circle ci has passed
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
…dit-card-payments
Thanks for reviewing @fivetran-jamie! I just updated the package based off your notes and will plan to merge with the dbt-utils and dbt-core updates. |
b2ab899
into
MagicBot/dbt-utils-cross-db-migration
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Features
credit_card_payment_txn
(enabled/disabled using theusing_credit_card_payment_txn
variable) source as well as the accompanying staging models. This source includes all credit card payment transactions and will be used in downstream General Ledger generation to ensure accurate reporting of all transaction types.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
This PR will only add a new intermediate and component in the GL model that is disabled by default. This will not cause existing runs to fail.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💳
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.