Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for dbt-utils to dbt-core cross-db macro migration #15

Merged
merged 28 commits into from
Dec 20, 2022

Conversation

fivetran-sheringuyen
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen commented Oct 17, 2022

This pull request was created automatically 🎉
Before merging this PR (refer to Detailed Update Sheet 10/2022 for more information):

  • Verify dbt_project.yml & integration_tests/dbt_project.yml versions are properly bumped
  • Spot check for dispatch updates, dbt_utils.macro -> dbt.macro
  • Verify that .circleci directory has been removed
  • Verify integration_tests/requirements.txt adapters have been updated to 1.2.0 and dbt-databricks is added
  • Verify .buildkite directory has been added with the following: hooks/pre-command, scripts/run_models.sh, pipeline.yml
  • Update packages.yml, will need to bump source package (FT utils should be bumped)
  • Update .buildkite/scripts/run_models.sh with vars as applicable, if N/A then remove relevant lines from script
  • Remove databricks block from .buildkite/pipeline.yml if package is incompatible
  • Update schema names in integration_tests/ci/sample.profiles.yml
  • Update "spark" strings where applicable
  • Update CHANGELOG template and remove surrogate keys if not applicable to package
  • Update README for dbt version badge, install package version range and dependencies for: Fivetran_utils, dbt-utils and source packages
  • Regenerate docs
  • Follow Instructions for adding Buildkite
  • Follow instructions for removing Circleci

@fivetran-reneeli
Copy link
Contributor

  • need to update readme

@fivetran-reneeli
Copy link
Contributor

Error on dbt run:


Compilation Error in model klaviyo__flows (models/klaviyo__flows.sql)
  
  Warning: `dbt_utils.surrogate_key` has been replaced by `dbt_utils.generate_surrogate_key`. The new macro treats null values differently to empty strings. To restore the behaviour of the original macro, add a variable scoped to the dbt_utils package called `surrogate_key_treat_nulls_as_empty_strings` to your dbt_project.yml file with a value of True. The klaviyo.klaviyo__flows model triggered this warning. 
  
  > in macro default__surrogate_key (macros/sql/surrogate_key.sql)
  > called by macro surrogate_key (macros/sql/surrogate_key.sql)
  > called by model klaviyo__flows (models/klaviyo__flows.sql)

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 5b33b6a into main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update_type:dependency Primary focus is to update dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants