Add Membrane.AWS.S3.Source #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karolk99
requested changes
Feb 29, 2024
mix.exs
Outdated
|
|
||
| # Test dependency | ||
| {:bypass, "~> 2.1", only: :test}, | ||
| {:httpoison, "~> 2.0", only: :test}, |
There was a problem hiding this comment.
It's also never used
Suggested change
| {:httpoison, "~> 2.0", only: :test}, |
There was a problem hiding this comment.
https://hexdocs.pm/ex_aws/ExAws.Request.HttpClient.html. I think we should add hackney to mix dependencies. If a user wants to change the HTTP library he can do it itself.
Comment on lines
+9
to
+10
| def_options aws_config: [ | ||
| spec: Keyword.t(), |
There was a problem hiding this comment.
I don't see any example in Readme or type for aws_config. I think that it would be nice to know what keywords you have to pass to access a s3 bucket.
Co-authored-by: Karol Konkol <56369082+Karolk99@users.noreply.github.com>
Co-authored-by: Karol Konkol <56369082+Karolk99@users.noreply.github.com>
Karolk99
approved these changes
Mar 1, 2024
lib/s3/s3_source.ex
Outdated
|
|
||
| @impl true | ||
| def handle_init(_context, opts) do | ||
| state = %{ |
There was a problem hiding this comment.
I think Map.merge would look better
lib/s3/s3_source.ex
Outdated
| |> Task.async_stream( | ||
| &download_chunk(state, &1), | ||
| max_concurrency: Keyword.get(state.opts, :max_concurrency, 8), | ||
| timeout: Keyword.get(state.opts, :timeout, 60_000) |
There was a problem hiding this comment.
I would move the timeout value to the attribute variable
Co-authored-by: Karol Konkol <56369082+Karolk99@users.noreply.github.com>
Co-authored-by: Karol Konkol <56369082+Karolk99@users.noreply.github.com>
Co-authored-by: Karol Konkol <56369082+Karolk99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.