Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar fixes; mmap alloc failed error remark for Arch Linux. #1660

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

murlakatamenka
Copy link
Contributor

Just a few grammar fixes in the docs.
Also a remark on fixing mmap alloc failed on Arch Linux and its derivatives. It should also be relevant for Fedora but I'm not its user (and didn't bother checking via VM or docker), needs confirmation from actual ones.

@Spudz76
Copy link
Contributor

Spudz76 commented Jun 14, 2018

The Arch instruction is generally correct for all distros, main monolithic sysctl.conf has been deprecated for a while more or less globally, or at least the newer subfolder method had been enabled so it works either way even on old distros.

Also less clashy with package manager updating config files which was the whole reason for the subfolder and locally named files that won't exist in the distro package.

The limits stuff also has a .d subfolder and is technically outdated methodology in the docs as well. And if you run as root most recent distros require explicit root mentioned not just * as it no longer includes root. So docs slightly off about that also.

I personally also install sysfsutils and use its .d folder to setup power management and process scheduling for CPUs which isn't even in the docs (it doesn't make a huge difference anyway).

@murlakatamenka
Copy link
Contributor Author

@Spudz76 thanks for clearing this out! I wasn't sure so decided to put a remark in a safe manner.
Yes, with a folder method it's definitely easier to deal with config files.

I'll update the doc a little bit taking into account your comment.

@psychocrypt psychocrypt self-assigned this Jul 14, 2018
@psychocrypt
Copy link
Collaborator

I will merge the PR as it is if there are further changes needed please open a new PR.

@psychocrypt psychocrypt merged commit 801ab27 into fireice-uk:dev Jul 14, 2018
@psychocrypt psychocrypt mentioned this pull request Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants