feat: add possibility to change update strategy

[okaufmann]

Changes in this pull request:

• Introduce a configuration option to customize the update strategy. This enhancement is particularly beneficial for scenarios involving ReadWriteOnce (RWO) PersistentVolumeClaims (PVCs), where a PVC can be mounted by only one Pod at a time.

[JC5]

Nice. Could you pick up the lint feedback as well?

[okaufmann]

I've set the new version to 1.8.0 as this is a new feature and I guess you are following Semver. If this is not what you want, let me know.

[JC5]

That's a great idea. And now for the million dollar question: did you test it, and does it work as expected?

[okaufmann]

@JC5 Yes, I run some tests locally and in my Cluster:

cd charts/firefly-iii

helm template test . -f values.yaml

This generated (among the other templates) this Deployment Manifest:

# Source: firefly-iii/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: test-firefly-iii
  labels:
    helm.sh/chart: firefly-iii-1.8.0
    app.kubernetes.io/name: firefly-iii
    app.kubernetes.io/instance: test
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  strategy:
    type: RollingUpdate
  # ......

After setting deploymentStrategyType to, and generate the manifest again, I've got this expected output:

# Source: firefly-iii/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: test-firefly-iii
  labels:
    helm.sh/chart: firefly-iii-1.8.0
    app.kubernetes.io/name: firefly-iii
    app.kubernetes.io/instance: test
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  strategy:
    type: Recreate
  # ......

I've also updated my Deployment directly on my Cluster and checked it was valid, and it was:

I've removed the additionalrollingUpdate config, which is still visible in the Screenshot (Cannot be there when strategy was set to Recreate). Furthermore, I think when Helm is generating the new Manifests, this config won't be generated and removed automatically on a Chart update after updating deploymentStrategyType in the values.

[JC5]

Thanks, merged!