Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@fireblocks/recovery-utility): ✨ add Jetton support #105

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

TomerHFB
Copy link
Collaborator

Add the ability to derive Jetton wallets a withdraw the assets

Add the ability to derive Jetton wallets a withdraw the assets
@TomerHFB TomerHFB requested a review from a0ngo December 16, 2024 09:22
apps/recovery-relay/components/WithdrawModal/index.tsx Outdated Show resolved Hide resolved
apps/recovery-relay/context/Workspace.tsx Show resolved Hide resolved
apps/recovery-relay/lib/wallets/Jetton/index.ts Outdated Show resolved Hide resolved
apps/recovery-utility/renderer/lib/wallets/index.ts Outdated Show resolved Hide resolved
apps/recovery-utility/renderer/lib/wallets/index.ts Outdated Show resolved Hide resolved
packages/shared/lib/validateAddress.ts Outdated Show resolved Hide resolved
packages/wallet-derivation/wallets/chains/index.ts Outdated Show resolved Hide resolved
@TomerHFB
Copy link
Collaborator Author

Fixes applied @a0ngo

Copy link
Collaborator

@a0ngo a0ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +448 to +449
prepareQuery.data?.insufficientBalanceForTokenTransfer !== undefined &&
prepareQuery.data.insufficientBalanceForTokenTransfer)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prepareQuery.data?.insufficientBalanceForTokenTransfer !== undefined &&
prepareQuery.data.insufficientBalanceForTokenTransfer)
prepareQuery.data.insufficientBalanceForTokenTransfer)

@a0ngo a0ngo merged commit 3586b35 into main Dec 18, 2024
@TomerHFB TomerHFB deleted the feat/add-jetton-support branch December 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants