Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assetId to gas-station configuration #76

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

shirGerasi1
Copy link
Contributor

@shirGerasi1 shirGerasi1 commented Feb 20, 2022

Pull Request Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added the enhancement New feature or request label Feb 20, 2022
@yarinvak yarinvak merged commit 73313c6 into master Mar 3, 2022
@yarinvak yarinvak deleted the COR-11469-addAssetId branch March 3, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants