Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing fields to TransactionResponse #69

Merged
merged 1 commit into from
Dec 20, 2021
Merged

fix: add missing fields to TransactionResponse #69

merged 1 commit into from
Dec 20, 2021

Conversation

yarinvak
Copy link
Contributor

@yarinvak yarinvak commented Dec 20, 2021 •
edited
Loading

Pull Request Description

Add missing fields to TransactionResponse interfaces
Fixes (#68)

Type of change

  • [ X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels Dec 20, 2021
@yarinvak yarinvak removed the enhancement New feature or request label Dec 20, 2021
@yarinvak yarinvak merged commit eaf8620 into master Dec 20, 2021
@yarinvak yarinvak deleted the add-missing-tx-response-fields branch December 20, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] amountInfo not found in TransactionResponse
1 participant
@yarinvak