Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add externalId in WriteCallFunctionDto, add SDK to support fee and feeLevel #298

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Add externalId in WriteCallFunctionDto, add SDK to support fee and feeLevel #298

merged 5 commits into from
Oct 24, 2024

Conversation

mlyberopoulos
Copy link
Contributor

@mlyberopoulos mlyberopoulos commented Oct 24, 2024 •
edited by YoavBZ
Loading

Pull Request Description

  • Add support externalTxnId in the WriteCallFunctionDto
  • Update SDK to support fee and feeLevel

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

phanigovindaraju
phanigovindaraju requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@phanigovindaraju phanigovindaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Looks good otherwise

phanigovindaraju
phanigovindaraju reviewed Oct 24, 2024
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@phanigovindaraju phanigovindaraju merged commit 9baa06a into fireblocks:master Oct 24, 2024
6 checks passed
@YoavBZ YoavBZ changed the title OC-5460 - Add externalId in WriteCallFunctionDto && OC-5461 - Add SDK to support fee and feeLevel Add externalId in WriteCallFunctionDto, add SDK to support fee and feeLevel Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanigovindaraju phanigovindaraju phanigovindaraju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlyberopoulos @phanigovindaraju