Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with add abi #291

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix issue with add abi #291

merged 3 commits into from
Aug 28, 2024

Conversation

phanigovindaraju
Copy link
Collaborator

@phanigovindaraju phanigovindaraju commented Aug 14, 2024

Pull Request Description

Fixes the following issues

  • abi and name missing in add abi endpoint
  • fixes routes

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels Aug 14, 2024
@phanigovindaraju phanigovindaraju requested a review from or109 August 14, 2024 12:41
@phanigovindaraju phanigovindaraju merged commit 76910d0 into master Aug 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants