Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenization Collection API - Changed token metadata objects' fields from camel Case to snake case #288

Conversation

trongvnau
Copy link
Contributor

Pull Request Description

Updated collection api: token metadata object and collection token metadata attribute object to have object field names in snake_case instead of camelCase.

e.g. update externalUrl to external_url

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@phanigovindaraju phanigovindaraju merged commit 36b3d90 into fireblocks:master Jul 29, 2024
6 checks passed
@YoavBZ YoavBZ changed the title [OC-4662] Tokenization Collection API - Changed token metadata objects' fields from camel Case to snake case Tokenization Collection API - Changed token metadata objects' fields from camel Case to snake case Jul 30, 2024
@YoavBZ YoavBZ added the bug Something isn't working label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants