Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link contract routes #287

Merged
merged 17 commits into from
Aug 5, 2024
Merged

Add link contract routes #287

merged 17 commits into from
Aug 5, 2024

Conversation

phanigovindaraju
Copy link
Collaborator

@phanigovindaraju phanigovindaraju commented Jul 25, 2024 •
edited
Loading

Pull Request Description

Adds new routes and updates existing routes to support "Link any contract" feature

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added the enhancement New feature or request label Jul 25, 2024
@phanigovindaraju phanigovindaraju requested a review from or109 July 29, 2024 01:09
or109
or109 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@or109 or109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
@phanigovindaraju phanigovindaraju merged commit 99972c4 into master Aug 5, 2024
8 checks passed
@dolevmiz1 dolevmiz1 mentioned this pull request Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@or109 or109 or109 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phanigovindaraju @or109