Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update type of addressFormat to string | undefined #243

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ankitshubham97
Copy link
Contributor

@ankitshubham97 ankitshubham97 commented Jan 15, 2024

Pull Request Description

The bug fix involves correcting the data type for the addressFormat property in the SDK code. Currently, the addressFormat is defined as a number in the code. The correction should update the data type to a string | undefined for the addressFormat property in the AddressResponse interface. This adjustment ensures consistency and compatibility with the actual data type used for addressFormat in the underlying implementation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran build command and used the new custom SDK in my Express app. Works fine now and I do not see the compile-time error. I am using Typescript in the Express app.

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@dsahni dsahni requested a review from YoavBZ January 18, 2024 18:50
@YoavBZ YoavBZ merged commit d57d3c4 into fireblocks:master Jan 18, 2024
7 checks passed
@YoavBZ
Copy link
Collaborator

YoavBZ commented Jan 18, 2024

Thanks @ankitshubham97 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants