Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert mistake in updateVaultAccount #224

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Revert mistake in updateVaultAccount #224

merged 1 commit into from
Nov 16, 2023

Conversation

gadiguy
Copy link
Contributor

@gadiguy gadiguy commented Nov 16, 2023

Pull Request Description

Function updateVaultAccount used post instead of put, and had a redundant parameter. This commit fixes that.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • [n/a ] I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • [n/a] I have added corresponding labels to the PR

@zoharsf zoharsf merged commit 340fdaa into fireblocks:master Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoharsf zoharsf zoharsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadiguy @zoharsf