-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staking sdk #216
Staking sdk #216
Conversation
# Conflicts: # src/fireblocks-sdk.ts
# Conflicts: # src/fireblocks-sdk.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing this internally - new methods should be added to the FireblocksSDK
class and not in a new one. We should keep the current approach of not introducing new namespaces (NCW is exceptional).
Please align this accordingly
@YoavBZ |
@YoavBZ We are trying to be similar as possible to they way the auto generated SDK will create our API (from we understand it will be under a separate namespace). As this is a new API and we want to make sure the migration from this SDK to new one will be streamlined as much as possible for clients. |
…for staking/unstake/withdraw
Pull Request Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes (link to the issue here)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: