Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bulk functions #209

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Conversation

gadiguy
Copy link
Contributor

@gadiguy gadiguy commented Sep 11, 2023

Pull Request Description

Added bulk functions and job control functions.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@zoharsf zoharsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a single comment, other than that looks good to me

@zoharsf zoharsf merged commit ed3127e into fireblocks:master Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants