Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP Endpoints #207

Merged
merged 1 commit into from
Sep 11, 2023
Merged

TAP Endpoints #207

merged 1 commit into from
Sep 11, 2023

Conversation

asafs932
Copy link
Collaborator

@asafs932 asafs932 commented Sep 5, 2023

Pull Request Description

Adding TAP (Transaction Authorization Policy) endpoints in BETA mode( being FF):

  • get active policy
  • get draft
  • update draft
  • publish draft
  • publish policy rules

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added the enhancement New feature or request label Sep 5, 2023
@asafs932 asafs932 force-pushed the add-tap-endpoints-to-sdk-js branch from 9773132 to 3fcc4a4 Compare September 6, 2023 10:24
@asafs932 asafs932 force-pushed the add-tap-endpoints-to-sdk-js branch from 3fcc4a4 to e4fd43f Compare September 6, 2023 12:32
@asafs932 asafs932 requested review from YoavBZ and zoharsf September 6, 2023 13:56
@YoavBZ YoavBZ changed the title feat: adding tap endpoints TAP Endpoints Sep 11, 2023
@YoavBZ YoavBZ merged commit d12aab5 into master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants