Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added list owned assets endpoint and NCW for NFTs #206

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

lazars14-f
Copy link
Collaborator

Pull Request Description

This mr adds the following:

  • status filter for get owned NFTs collections
  • list owned NFT assets endpoint
  • NCW filters for NFT endpoints

Fixes (link to the issue here)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@lazars14-f lazars14-f added the enhancement New feature or request label Sep 5, 2023
@lazars14-f lazars14-f self-assigned this Sep 5, 2023
@lazars14-f lazars14-f requested a review from aviba September 5, 2023 09:49
@aviba aviba merged commit 8e0f88c into master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants