Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NCW feature #192

Merged
merged 3 commits into from
Aug 20, 2023
Merged

add NCW feature #192

merged 3 commits into from
Aug 20, 2023

Conversation

amper-fb
Copy link
Contributor

@amper-fb amper-fb commented Aug 16, 2023

Pull Request Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

Copy link
Collaborator

@YoavBZ YoavBZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amper-fb for the contribution.
We haven't introduced namespaces in our SDK so far so adding one really changes the UX.
We might better do this in our new SDK and keep the current structure of this SDK.
@dsahni @zoharsf

src/api-client.ts Outdated Show resolved Hide resolved
@amper-fb
Copy link
Contributor Author

Thanks @amper-fb for the contribution. We haven't introduced namespaces in our SDK so far so adding one really changes the UX. We might better do this in our new SDK and keep the current structure of this SDK. @dsahni @zoharsf

how does it "really change the UX"?

@YoavBZ
Copy link
Collaborator

YoavBZ commented Aug 17, 2023

Thanks @amper-fb for the contribution. We haven't introduced namespaces in our SDK so far so adding one really changes the UX. We might better do this in our new SDK and keep the current structure of this SDK. @dsahni @zoharsf

how does it "really change the UX"?

We talked about adding namespaces a long time ago and eventually decided not to do it in this SDK (we do that in our next-gen SDK)
Adding a namespace to only one group of methods is confusing and doesn't follow the current structure

@amper-fb amper-fb changed the title Ncw (with Namespace) add NCW feature Aug 20, 2023
@YoavBZ YoavBZ merged commit 8a73b3a into fireblocks:master Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants