Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed return type to pending instead of TokenLink #188

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

amimagid
Copy link
Collaborator

@amimagid amimagid commented Aug 9, 2023

Pull Request Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@amimagid amimagid requested a review from idanya August 9, 2023 12:18
src/types.ts Show resolved Hide resolved
src/fireblocks-sdk.ts Outdated Show resolved Hide resolved
Ami Magid and others added 2 commits August 10, 2023 15:21
Co-authored-by: Idan Yael <idanya@users.noreply.github.com>
@idanya idanya merged commit 8c4a3bc into master Aug 10, 2023
@idanya idanya deleted the WEB3-1775 branch August 10, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants