-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for axios response interceptor, remove deprecated methods #141
Conversation
…ders in response BREAKING CHANGE: changed response type for all of API methods, and removed deprecated transfer-assist operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider refactoring and extracting all the different request methods logic to a single function that uses this.axiosInstance.request()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return await
is considered redundant, please avoid using it (unless in try-catch block)
@YoavBZ where do you see it in my changes? I'm not going to fix all old usages in this PR |
# Conflicts: # src/fireblocks-sdk.ts
… the response header
BREAKING CHANGE: getVaultAccounts, getVaultAccount, getExchangeAccount methods were removed and replaced by getVaultAccountsWithPageInfo, getVaultAccountById, getExchangeAccountById - check the migration guide in README.md
BREAKING CHANGE: removed all deprecated SDK methods
Pull Request Description
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: