Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SDKOptions fields optional #123

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Make SDKOptions fields optional #123

merged 1 commit into from
Nov 24, 2022

Conversation

YoavBZ
Copy link
Collaborator

@YoavBZ YoavBZ commented Nov 23, 2022

Pull Request Description

SDKOption shouldn't be required but optional, according to the use case.

Type of change

  • Enhancement (non-breaking change)

How Has This Been Tested?

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@YoavBZ YoavBZ added the enhancement New feature or request label Nov 23, 2022
@YoavBZ YoavBZ self-assigned this Nov 23, 2022
@sashalinder sashalinder merged commit 45f4a40 into master Nov 24, 2022
@YoavBZ YoavBZ deleted the optional-sdk-options branch December 6, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashalinder sashalinder sashalinder approved these changes

@yarinvak yarinvak Awaiting requested review from yarinvak

Assignees

@YoavBZ YoavBZ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoavBZ @sashalinder