Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotations to support < Python3.9 #22

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Fix type annotations to support < Python3.9 #22

merged 5 commits into from
Jan 11, 2023

Conversation

YoavBZ
Copy link
Collaborator

@YoavBZ YoavBZ commented Jan 9, 2023

Pull Request Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels Jan 9, 2023
@YoavBZ YoavBZ self-assigned this Jan 9, 2023
@YoavBZ YoavBZ merged commit fdc6543 into main Jan 11, 2023
@YoavBZ YoavBZ mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashalinder sashalinder sashalinder approved these changes

@orenyomtov orenyomtov Awaiting requested review from orenyomtov

@yanlevi yanlevi Awaiting requested review from yanlevi

Assignees

@YoavBZ YoavBZ

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chain.py is an enum but contains multiple entries for ARBITRUM. Requires >= Python 3.9
2 participants
@YoavBZ @sashalinder