Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit code sign identity for catalyst #1664

Merged
merged 2 commits into from
Jan 16, 2025
Merged

add explicit code sign identity for catalyst #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d1bc1
add explicit code sign identity for catalyst
morganchen12 Jan 15, 2025
70ecc4f
disable test execution for catalyst
morganchen12 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/abtesting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
test: false
- os: catalyst
device: localhost
test: true
test: false # disabled due to a permissions error on launch (OSStatus -54).
env:
SETUP: abtesting
SPM: true
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/analytics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,23 @@ jobs:
include:
- os: iOS
device: iPhone 16
test: true
- os: catalyst
device: localhost
test: false # disabled due to a permissions error on launch (OSStatus -54).
- os: tvOS
device: Apple TV 4K (3rd generation) (at 1080p)
scheme: AnalyticsExampleTV
test: true
- os: macOS
device: localhost
scheme: AnalyticsExampleMac
test: true
env:
SPM: false
LEGACY: false
OS: ${{ matrix.os }}
DEVICE: ${{ matrix.device }}
TEST: true
SCHEME: ${{ matrix.scheme }}
DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer
steps:
Expand All @@ -67,6 +70,7 @@ jobs:
- name: Build Swift
run: ./scripts/test.sh
env:
TEST: ${{ matrix.test }}
SWIFT_SUFFIX: ""

#TODO: Add `spm` job.
1 change: 1 addition & 0 deletions scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ fi
flags+=(
CODE_SIGNING_REQUIRED=NO
CODE_SIGNING_ALLOWED=NO
CODE_SIGN_IDENTITY=-
build
)

Expand Down
Loading