Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support references in eval:flow #63

Merged
merged 4 commits into from
May 8, 2024
Merged

Support references in eval:flow #63

merged 4 commits into from
May 8, 2024

Conversation

ssbushi
Copy link
Contributor

@ssbushi ssbushi commented May 7, 2024

No description provided.

@ssbushi ssbushi requested review from tagboola and schnecle May 7, 2024 20:16
Copy link
Contributor

@tagboola tagboola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small comments 🙂

genkit-tools/src/commands/eval-flow.ts Outdated Show resolved Hide resolved
genkit-tools/common/src/types/eval.ts Outdated Show resolved Hide resolved
@ssbushi ssbushi requested a review from tagboola May 8, 2024 17:04
return EvalFlowInputSchema.parse(parsedData);
} catch (e) {
throw new Error(
`Error parsing the input. Please provide an array of inputs for the flow or a ${EVAL_FLOW_SCHEMA} object`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include the error details in the message so they know why it failed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ssbushi ssbushi merged commit c0aa9ba into main May 8, 2024
4 checks passed
@ssbushi ssbushi deleted the sb/referenceUnion branch May 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants