Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(py): refactoring a Plugin abstraction #2029

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

timere-nemo
Copy link
Contributor

Description:

  • Refactored a Plugin abstraction to make it more versatile in use.
  • Updated the VertexAI plugin and a code sample

Problem:

  1. Current implementation assumes that only one model is defined, whereas we may have multiple models.
  2. It is unclear why _model_callback needs to be defined in the Plugin. Since each model (or model family) has its own execution logic, it should provide its own callback

Checklist (if applicable):

@timere-nemo timere-nemo self-assigned this Feb 19, 2025
Copy link

google-cla bot commented Feb 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the python Python label Feb 19, 2025
@timere-nemo timere-nemo requested review from kirgrim and removed request for kirgrim February 19, 2025 14:33
@timere-nemo timere-nemo marked this pull request as draft February 19, 2025 14:35
@timere-nemo timere-nemo marked this pull request as ready for review February 19, 2025 16:40
@timere-nemo timere-nemo requested a review from pavelgj February 19, 2025 17:11
@timere-nemo timere-nemo merged commit f14dd58 into main Feb 21, 2025
7 checks passed
@timere-nemo timere-nemo deleted the ryermilov/plugin-abc branch February 21, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants