feat: add populate_by_name=True to all schema models inheriting from BaseModel #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
050ee29 to
08cb03d
Compare
tanyasingh1902
approved these changes
Feb 18, 2025
…BaseModel CHANGELOG: - [ ] We add the `populate_by_name=True` parameter to ensure serialization uses camelCase for attributes since the JS implementation uses camelCase and Python uses snake_case. The codegen pass is configured to genearte snake_case for a Pythonic API but serialize to camelCase in order to be compatible with runtimes. - [ ] Update `bin/fmt` to organize imports.
08cb03d to
5f9ddc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add populate_by_name=True to all schema models inheriting from BaseModel
CHANGELOG:
populate_by_name=Trueparameter to ensure serialization uses camelCase for attributes since the JS implementation uses camelCase and Python uses snake_case. The codegen pass is configured to generate snake_case for a Pythonic API but serialize to camelCase in order to be compatible with runtimes.bin/fmtto organize imports.Checklist (if applicable):