Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py): Refactored Plugins API to follow generic Plugin interface. #1950

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feat(py): Refactored Plugins API to follow generic Plugin interface. #1950

merged 1 commit into from
Feb 17, 2025
+149 −42

Conversation

kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Feb 12, 2025

Description

  • Refactored Plugin API to use generic genkit.core.plugin_abc.Plugin interface
  • Updated VertexAI implementation to follow the new specification

Checklist (if applicable):

@kirgrim kirgrim requested review from yesudeep and Irillit February 12, 2025 15:52
@github-actions github-actions bot added feature New feature or request python Python labels Feb 12, 2025
@kirgrim kirgrim requested a review from kamilkorski February 12, 2025 17:00
@kirgrim kirgrim force-pushed the hrymailo/feat/moving-py-genkit-plugins-to-classes branch from d5d1c5b to 6c20f99 Compare February 12, 2025 17:02
@kirgrim kirgrim requested a review from Irillit February 12, 2025 17:03
@kirgrim kirgrim force-pushed the hrymailo/feat/moving-py-genkit-plugins-to-classes branch from 6c20f99 to f0c4bb7 Compare February 12, 2025 17:14
@kirgrim kirgrim force-pushed the hrymailo/feat/moving-py-genkit-plugins-to-classes branch 2 times, most recently from 168cad7 to be033a4 Compare February 13, 2025 15:17
@kirgrim kirgrim requested a review from Irillit February 13, 2025 15:25
@yesudeep
Copy link
Contributor

Can you please rebase this PR? I think the PR checks should pass now

@yesudeep yesudeep added this to the py-0.1.0 milestone Feb 13, 2025
@kirgrim kirgrim force-pushed the hrymailo/feat/moving-py-genkit-plugins-to-classes branch from be033a4 to 03933a1 Compare February 14, 2025 10:54
@kirgrim kirgrim force-pushed the hrymailo/feat/moving-py-genkit-plugins-to-classes branch from 03933a1 to e2596ac Compare February 15, 2025 12:11
@kirgrim kirgrim force-pushed the hrymailo/feat/moving-py-genkit-plugins-to-classes branch from e2596ac to 8aca8e7 Compare February 15, 2025 12:19
@kirgrim kirgrim requested a review from kamilkorski February 15, 2025 12:20
@kirgrim kirgrim merged commit d5cc31a into main Feb 17, 2025
7 checks passed
@kirgrim kirgrim deleted the hrymailo/feat/moving-py-genkit-plugins-to-classes branch February 17, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irillit Irillit Irillit approved these changes

@yesudeep yesudeep Awaiting requested review from yesudeep

@kamilkorski kamilkorski Awaiting requested review from kamilkorski

Assignees
No one assigned
Labels
feature New feature or request python Python
Projects
Genkit Backlog
Status: Done
Milestone
py-0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kirgrim @yesudeep @Irillit @kamilkorski