feat(go): Added action-level and generate-level middleware. #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 12, 2025
pavelgj
reviewed
Feb 18, 2025
| // TODO: use a generic type alias for the above when they become available? | ||
| // Middleware is a function that wraps an action execution, similar to HTTP middleware. | ||
| // It can modify the input, output, and context, or perform side effects. | ||
| type Middleware[In, Out, Stream any] = func(ctx context.Context, input In, cb func(context.Context, Stream) error, next Func[In, Out, Stream]) (Out, error) |
There was a problem hiding this comment.
This middleware signature is similar to js (express) middleware and I'm OK with it, but in Go a more idiomatic signature might be:
type Middleware[I, O, S any] func(Func[I, O, S]) Func[I, O, S]Similar to https://pkg.go.dev/go.ntrrg.dev/ntgo/net/http/middleware
I had it previously proposed in https://github.com/firebase/genkit/pull/429/files#diff-181ec49997af46351ae6b830a6c8883400c96f71628a4198a988e23b7d461d09
I'm OK either way, just asking if you considered it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1945, #1940, #1727.
Checklist (if applicable):