Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the requirement to send click_action: FLUTTER_NOTIFICATION_CLICK for Android #1338

Closed
WinkMeter opened this issue Oct 31, 2019 · 1 comment
Labels

Comments

@WinkMeter
Copy link

WinkMeter commented Oct 31, 2019

Is your feature request related to a problem? Please describe.
Currently we would have to send click_action: FLUTTER_NOTIFICATION_CLICK as part of the message sent to apps using the Flutter firebase_messaging plugin for Android apps to wake up from the background and deliver the notification data to the app. This requirement creates a problem in an environments with apps created using different platforms. (Flutter, Xamrin, Native, etc...)

The problem with this is that it adds a dependency to the backend which has to know when (i.e. Flutter vs. non-flutter apps) it needs to include the click_action to the push message. Sending "click_action" to all apps doesn't make sense. In other words, there's a tight coupling between the app and the backend.

Describe the solution you'd like
It would be nice if Android clients don't have to depend on this and just work like how iOS does it by default without this "click_action" information being included in the push message. In other words, remove the "client_action" requirement and only needs it to pass "specific" actions.

Additional context
Is there another way to get around not having to include "click_action"?

@WinkMeter WinkMeter added the type: enhancement New feature or request label Oct 31, 2019
Ehesp pushed a commit that referenced this issue Oct 20, 2020
@Salakar
Copy link
Member

Salakar commented Nov 5, 2020

Hey 👋

As part of our roadmap (#2582) we've just shipped a complete rework of the firebase_messaging plugin that aims to solve this and many other issues, specifically FLUTTER_NOTIFICATION_CLICK no longer exists and is not required anymore - all notification 'clicks' for FCM notifications will go through the message handlers now.

If you can, please try out the dev release (see the migration guide for upgrading and for changes) and if you have any feedback then join in the discussion here.

Thanks

@Salakar Salakar closed this as completed Nov 5, 2020
@firebase firebase locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants