-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Firebase v9 (compat) #850
Conversation
A release candidate for this has been cut to NPM for external testing, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I responded to that one, looks like its been fixed in Firebase v9.1.2 |
@treeder there should be no need for a new version on |
What is currently stopping this PR to be merged to master? |
@OrhanTozan waiting for review and a green light from the FirebaseUI team. |
We will focus on the remaining review and getting this in this week. Sorry for the delay. We had to make sure we tested all the flows first (in dependent libraries too) and fixed any issues in the compat layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together @jamesdaniels! Changes look great! I just have a bunch of nits and minor requests. Should be straightforward to resolve.
@@ -1939,6 +1923,26 @@ can verify in the [demo app](https://fir-ui-demo-84a6c.firebaseapp.com/)). | |||
|
|||
**For v1.0.0 and superior:** https://github.com/firebase/firebaseui-web/releases | |||
|
|||
### 6.0.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree with @jamesdaniels (let's not communicate any plans yet). Let's just focus on informing customers that v6.0.0 should be used with firebase version v9 (compat)and higher. We can also explain some of the changes needed when switching from v8 to v9 (such as the difference in how app and auth are imported or included via cdn, etc.) We can also mention the benefit when using firebaseui v6.0.0 with other v9 firebase services, such as firestore (when it comes to modularization). The description below seems to cover most of that.
This comment has been minimized.
This comment has been minimized.
@xil222 please help with the release for this change. Thank you. |
I have issue with Firebase v9.9 and Firebaseui v 6.0 |
firebase/*
tofirebase/compat/*
in the build step/demo
to use Firebase JS SDK v9.1.2 from the CDNgulp-concat-css
as the version in the package.json was not working for me, it was bailing during the inline images stepUsage:
npm i --save firebaseui@next firebase