Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up project selection when running in IDX #7550

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Pick up project selection when running in IDX #7550

merged 2 commits into from
Aug 12, 2024

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Aug 12, 2024

Description

Pick up project selection when running in IDX, and clean up currentProject.

Scenarios Tested

Tested this in IDX and confirmed that we pick up the selected project without extra action from the user.
Tested this in local VSCode and confirmed that we still pick up the .firebaserc default project.
Would definitely appreciate extra testing here tho.

@hlshen hlshen self-requested a review August 12, 2024 18:36
@joehan joehan enabled auto-merge (squash) August 12, 2024 19:54
@joehan joehan merged commit f9fff1b into master Aug 12, 2024
41 checks passed
@joehan joehan requested a review from hlshen August 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants