Use esbuild lib instead of npx #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesdaniels this would address #7250 and #6193, WDYT? |
|
We use to do this. The trouble here is that firebase-tools pins dependencies. So we were pinning to a version of esbuild that was not supported on customer's machines, be it node version or architecture. Perhaps we could be smart and do some equivalent of "npm install" and "npm which" |
jamesdaniels
requested changes
Jul 8, 2024
- Add `findEsbuildPath`: Helper function to find the path of esbuild using `npm which` - Add `installEsbuild`: Helper function to install esbuild dynamically - Add tests for `findEsbuildPath` and `installEsbuild`
jamesdaniels
approved these changes
Jul 15, 2024
leoortizz
reviewed
Jul 15, 2024
leoortizz
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for this #7250 and #6193 where
esbuildexecution was throwing an error saying "Command line too long" on Windows.It tries to find an installed version of
esbuildusingnpm which, if it is not found then it tries to install it. Once it is able to find a path toesbuild, it dynamically imports it and uses it to bundle the next.config file.If the version of the installed esbuild doesn't match the required version, it will show a warning in the terminal.
Scenarios Tested