sql:migrate --force should ignore invalid connector
#7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sql:migrate --force should ignore invalid connector
joehan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI/CD CUJ on non-prod workflow should set cloud sql state to whatever is in local configs. The following two commands should always work regardless of destructive schema migration of invalid connectors.
Previous,
dataconnect:sql:migrate --forceaborts upon invalid connector. This PR handles this edge case.Scenarios Tested
firebase deploywith invalid connectorsfirebase dataconnect:sql:migratewith invalid connectorsfirebase dataconnect:sql:migrate --forcewith invalid connectorsSample Commands